complete story 8.2 with qa tests
This commit is contained in:
Naser Mansour
parent
911624901f
commit
d1016c89f8
|
|
@ -0,0 +1,67 @@
|
||||||
|
<?php
|
||||||
|
|
||||||
|
namespace App\Mail;
|
||||||
|
|
||||||
|
use App\Models\User;
|
||||||
|
use Illuminate\Bus\Queueable;
|
||||||
|
use Illuminate\Contracts\Queue\ShouldQueue;
|
||||||
|
use Illuminate\Mail\Mailable;
|
||||||
|
use Illuminate\Mail\Mailables\Content;
|
||||||
|
use Illuminate\Mail\Mailables\Envelope;
|
||||||
|
use Illuminate\Queue\SerializesModels;
|
||||||
|
|
||||||
|
class WelcomeEmail extends Mailable implements ShouldQueue
|
||||||
|
{
|
||||||
|
use Queueable, SerializesModels;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Create a new message instance.
|
||||||
|
*/
|
||||||
|
public function __construct(
|
||||||
|
public User $user,
|
||||||
|
public string $password
|
||||||
|
) {
|
||||||
|
$this->locale = $user->preferred_language ?? 'ar';
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Get the message envelope.
|
||||||
|
*/
|
||||||
|
public function envelope(): Envelope
|
||||||
|
{
|
||||||
|
$locale = $this->user->preferred_language ?? 'ar';
|
||||||
|
|
||||||
|
return new Envelope(
|
||||||
|
subject: $locale === 'en'
|
||||||
|
? 'Welcome to Libra Law Firm'
|
||||||
|
: 'مرحباً بك في مكتب ليبرا للمحاماة',
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Get the message content definition.
|
||||||
|
*/
|
||||||
|
public function content(): Content
|
||||||
|
{
|
||||||
|
$locale = $this->user->preferred_language ?? 'ar';
|
||||||
|
|
||||||
|
return new Content(
|
||||||
|
markdown: 'emails.welcome.'.$locale,
|
||||||
|
with: [
|
||||||
|
'user' => $this->user,
|
||||||
|
'password' => $this->password,
|
||||||
|
'loginUrl' => route('login'),
|
||||||
|
],
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Get the attachments for the message.
|
||||||
|
*
|
||||||
|
* @return array<int, \Illuminate\Mail\Mailables\Attachment>
|
||||||
|
*/
|
||||||
|
public function attachments(): array
|
||||||
|
{
|
||||||
|
return [];
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
@ -2,9 +2,11 @@
|
||||||
|
|
||||||
namespace App\Notifications;
|
namespace App\Notifications;
|
||||||
|
|
||||||
|
use App\Mail\WelcomeEmail;
|
||||||
|
use App\Models\User;
|
||||||
use Illuminate\Bus\Queueable;
|
use Illuminate\Bus\Queueable;
|
||||||
use Illuminate\Contracts\Queue\ShouldQueue;
|
use Illuminate\Contracts\Queue\ShouldQueue;
|
||||||
use Illuminate\Notifications\Messages\MailMessage;
|
use Illuminate\Mail\Mailable;
|
||||||
use Illuminate\Notifications\Notification;
|
use Illuminate\Notifications\Notification;
|
||||||
|
|
||||||
class WelcomeAccountNotification extends Notification implements ShouldQueue
|
class WelcomeAccountNotification extends Notification implements ShouldQueue
|
||||||
|
|
@ -29,17 +31,11 @@ class WelcomeAccountNotification extends Notification implements ShouldQueue
|
||||||
/**
|
/**
|
||||||
* Get the mail representation of the notification.
|
* Get the mail representation of the notification.
|
||||||
*/
|
*/
|
||||||
public function toMail(object $notifiable): MailMessage
|
public function toMail(object $notifiable): Mailable
|
||||||
{
|
{
|
||||||
$locale = $notifiable->preferred_language ?? 'ar';
|
/** @var User $notifiable */
|
||||||
|
return (new WelcomeEmail($notifiable, $this->password))
|
||||||
return (new MailMessage)
|
->to($notifiable->email);
|
||||||
->subject(__('emails.welcome_subject', [], $locale))
|
|
||||||
->view('emails.welcome', [
|
|
||||||
'user' => $notifiable,
|
|
||||||
'password' => $this->password,
|
|
||||||
'locale' => $locale,
|
|
||||||
]);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
|
||||||
|
|
@ -0,0 +1,46 @@
|
||||||
|
# Quality Gate: 8.2 Welcome Email
|
||||||
|
schema: 1
|
||||||
|
story: "8.2"
|
||||||
|
story_title: "Welcome Email (Account Created)"
|
||||||
|
gate: PASS
|
||||||
|
status_reason: "All acceptance criteria met, comprehensive test coverage (21 tests), proper queue implementation, bilingual support complete, no security concerns"
|
||||||
|
reviewer: "Quinn (Test Architect)"
|
||||||
|
updated: "2025-12-29T00:00:00Z"
|
||||||
|
|
||||||
|
waiver: { active: false }
|
||||||
|
|
||||||
|
top_issues: []
|
||||||
|
|
||||||
|
risk_summary:
|
||||||
|
totals: { critical: 0, high: 0, medium: 0, low: 0 }
|
||||||
|
recommendations:
|
||||||
|
must_fix: []
|
||||||
|
monitor: []
|
||||||
|
|
||||||
|
quality_score: 100
|
||||||
|
expires: "2026-01-12T00:00:00Z"
|
||||||
|
|
||||||
|
evidence:
|
||||||
|
tests_reviewed: 21
|
||||||
|
risks_identified: 0
|
||||||
|
trace:
|
||||||
|
ac_covered: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17]
|
||||||
|
ac_gaps: []
|
||||||
|
|
||||||
|
nfr_validation:
|
||||||
|
security:
|
||||||
|
status: PASS
|
||||||
|
notes: "Password in email is intentional per requirements (admin-created accounts). No sensitive data logged."
|
||||||
|
performance:
|
||||||
|
status: PASS
|
||||||
|
notes: "Email queued via ShouldQueue - non-blocking on HTTP requests."
|
||||||
|
reliability:
|
||||||
|
status: PASS
|
||||||
|
notes: "Queue retry mechanism handles delivery failures (from Story 8.1)."
|
||||||
|
maintainability:
|
||||||
|
status: PASS
|
||||||
|
notes: "Clean separation: WelcomeEmail mailable + WelcomeAccountNotification wrapper. Well-documented."
|
||||||
|
|
||||||
|
recommendations:
|
||||||
|
immediate: []
|
||||||
|
future: []
|
||||||
|
|
@ -14,27 +14,27 @@ So that **I can access the platform**.
|
||||||
## Acceptance Criteria
|
## Acceptance Criteria
|
||||||
|
|
||||||
### Trigger
|
### Trigger
|
||||||
- [ ] Sent automatically on user creation by admin
|
- [x] Sent automatically on user creation by admin
|
||||||
- [ ] Queued for performance (implements `ShouldQueue`)
|
- [x] Queued for performance (implements `ShouldQueue`)
|
||||||
- [ ] Triggered via model observer on User created event
|
- [x] Triggered via admin creation action (recommended approach per Technical Notes)
|
||||||
|
|
||||||
### Content
|
### Content
|
||||||
- [ ] Personalized greeting (name/company)
|
- [x] Personalized greeting (name/company)
|
||||||
- [ ] "Your account has been created" message
|
- [x] "Your account has been created" message
|
||||||
- [ ] Login credentials (email, password)
|
- [x] Login credentials (email, password)
|
||||||
- [ ] Login URL link with button
|
- [x] Login URL link with button
|
||||||
- [ ] Brief platform introduction
|
- [x] Brief platform introduction
|
||||||
- [ ] Contact info for questions
|
- [x] Contact info for questions
|
||||||
|
|
||||||
### Language
|
### Language
|
||||||
- [ ] Email in user's `preferred_language` field
|
- [x] Email in user's `preferred_language` field
|
||||||
- [ ] Default to Arabic ('ar') if `preferred_language` is null
|
- [x] Default to Arabic ('ar') if `preferred_language` is null
|
||||||
- [ ] Arabic template
|
- [x] Arabic template
|
||||||
- [ ] English template
|
- [x] English template
|
||||||
|
|
||||||
### Design
|
### Design
|
||||||
- [ ] Professional branding (inherits from base template in Story 8.1)
|
- [x] Professional branding (inherits from base template in Story 8.1)
|
||||||
- [ ] Call-to-action button: "Login Now" / "تسجيل الدخول"
|
- [x] Call-to-action button: "Login Now" / "تسجيل الدخول"
|
||||||
|
|
||||||
## Technical Notes
|
## Technical Notes
|
||||||
|
|
||||||
|
|
@ -122,18 +122,18 @@ The welcome email requires the plain-text password, which is only available at c
|
||||||
## Testing Requirements
|
## Testing Requirements
|
||||||
|
|
||||||
### Unit Tests
|
### Unit Tests
|
||||||
- [ ] `WelcomeEmail` mailable contains correct subject for Arabic user
|
- [x] `WelcomeEmail` mailable contains correct subject for Arabic user
|
||||||
- [ ] `WelcomeEmail` mailable contains correct subject for English user
|
- [x] `WelcomeEmail` mailable contains correct subject for English user
|
||||||
- [ ] `WelcomeEmail` uses correct template based on language
|
- [x] `WelcomeEmail` uses correct template based on language
|
||||||
- [ ] Default language is Arabic when `preferred_language` is null
|
- [x] Default language is Arabic when `preferred_language` is null
|
||||||
|
|
||||||
### Feature Tests
|
### Feature Tests
|
||||||
- [ ] Email is queued when user is created
|
- [x] Email is queued when user is created
|
||||||
- [ ] Arabic template renders without errors
|
- [x] Arabic template renders without errors
|
||||||
- [ ] English template renders without errors
|
- [x] English template renders without errors
|
||||||
- [ ] Email contains login URL
|
- [x] Email contains login URL
|
||||||
- [ ] Email contains user's password
|
- [x] Email contains user's password
|
||||||
- [ ] Email contains user's name
|
- [x] Email contains user's name
|
||||||
|
|
||||||
### Test Example
|
### Test Example
|
||||||
```php
|
```php
|
||||||
|
|
@ -162,15 +162,138 @@ test('welcome email uses arabic template by default', function () {
|
||||||
```
|
```
|
||||||
|
|
||||||
## Definition of Done
|
## Definition of Done
|
||||||
- [ ] `WelcomeEmail` mailable class created
|
- [x] `WelcomeEmail` mailable class created
|
||||||
- [ ] Arabic template (`emails/welcome/ar.blade.php`) created
|
- [x] Arabic template (`emails/welcome/ar.blade.php`) created
|
||||||
- [ ] English template (`emails/welcome/en.blade.php`) created
|
- [x] English template (`emails/welcome/en.blade.php`) created
|
||||||
- [ ] Email triggered on user creation by admin
|
- [x] Email triggered on user creation by admin
|
||||||
- [ ] Email is queued (not sent synchronously)
|
- [x] Email is queued (not sent synchronously)
|
||||||
- [ ] Credentials included in email
|
- [x] Credentials included in email
|
||||||
- [ ] Login button links to correct URL
|
- [x] Login button links to correct URL
|
||||||
- [ ] All tests pass
|
- [x] All tests pass
|
||||||
- [ ] Code formatted with Pint
|
- [x] Code formatted with Pint
|
||||||
|
|
||||||
## Estimation
|
## Estimation
|
||||||
**Complexity:** Low | **Effort:** 2-3 hours
|
**Complexity:** Low | **Effort:** 2-3 hours
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Dev Agent Record
|
||||||
|
|
||||||
|
### Status
|
||||||
|
Ready for Review
|
||||||
|
|
||||||
|
### Agent Model Used
|
||||||
|
Claude Opus 4.5
|
||||||
|
|
||||||
|
### File List
|
||||||
|
- `app/Mail/WelcomeEmail.php` (created)
|
||||||
|
- `resources/views/emails/welcome/ar.blade.php` (created)
|
||||||
|
- `resources/views/emails/welcome/en.blade.php` (created)
|
||||||
|
- `app/Notifications/WelcomeAccountNotification.php` (modified)
|
||||||
|
- `tests/Feature/Admin/WelcomeEmailTest.php` (modified)
|
||||||
|
|
||||||
|
### Change Log
|
||||||
|
- Created `WelcomeEmail` mailable class implementing `ShouldQueue`
|
||||||
|
- Created Arabic email template with RTL support
|
||||||
|
- Created English email template
|
||||||
|
- Updated `WelcomeAccountNotification` to use `WelcomeEmail` mailable
|
||||||
|
- Updated tests to validate mailable behavior (21 tests, all passing)
|
||||||
|
|
||||||
|
### Completion Notes
|
||||||
|
- Implementation follows the recommended trigger mechanism (dispatch from admin creation action) as specified in Technical Notes
|
||||||
|
- Existing `WelcomeAccountNotification` was updated to return `WelcomeEmail` mailable, maintaining the existing notification pattern
|
||||||
|
- Both `preferred_language` field and translations were already present from previous stories
|
||||||
|
- All 21 welcome email tests pass, plus 71 client management tests pass
|
||||||
|
|
||||||
|
## QA Results
|
||||||
|
|
||||||
|
### Review Date: 2025-12-29
|
||||||
|
|
||||||
|
### Reviewed By: Quinn (Test Architect)
|
||||||
|
|
||||||
|
### Code Quality Assessment
|
||||||
|
|
||||||
|
**Overall: Excellent implementation.** The story has been implemented cleanly and professionally following Laravel best practices.
|
||||||
|
|
||||||
|
**Key Strengths:**
|
||||||
|
- Proper separation of concerns: `WelcomeEmail` mailable handles email content/structure, `WelcomeAccountNotification` wraps it for notification delivery
|
||||||
|
- Both classes implement `ShouldQueue` ensuring async delivery and not blocking user creation
|
||||||
|
- Locale handling is correctly defaulting to Arabic ('ar') when `preferred_language` is null
|
||||||
|
- Templates use correct RTL support for Arabic and appropriate branding
|
||||||
|
- Integration with admin client creation flows is clean and well-tested
|
||||||
|
|
||||||
|
**Code Architecture:**
|
||||||
|
- `WelcomeEmail.php:24` - Locale set in constructor, ensuring consistent serialization for queued jobs
|
||||||
|
- `WelcomeEmail.php:32,46` - Defensive null-coalescing ensures default language even if property lost during queue serialization
|
||||||
|
- `WelcomeAccountNotification.php:34-38` - Returns mailable directly to leverage Laravel's mailable-as-notification pattern
|
||||||
|
|
||||||
|
### Refactoring Performed
|
||||||
|
|
||||||
|
No refactoring required. The code is well-structured and follows established patterns in the codebase.
|
||||||
|
|
||||||
|
### Compliance Check
|
||||||
|
|
||||||
|
- Coding Standards: [✓] Class-based approach, proper namespacing, Pint compliant
|
||||||
|
- Project Structure: [✓] Files in correct locations per Technical Notes
|
||||||
|
- Testing Strategy: [✓] 21 tests covering unit, integration, and edge cases
|
||||||
|
- All ACs Met: [✓] All 17 acceptance criteria verified complete
|
||||||
|
|
||||||
|
### Requirements Traceability
|
||||||
|
|
||||||
|
| AC | Description | Test Coverage |
|
||||||
|
|----|-------------|---------------|
|
||||||
|
| Trigger - Auto send on creation | ✓ | `welcome email is queued when creating individual client`, `...company client` |
|
||||||
|
| Trigger - Implements ShouldQueue | ✓ | `welcome notification implements should queue interface`, `welcome email mailable implements should queue interface` |
|
||||||
|
| Trigger - Via admin creation | ✓ | Tests use admin client creation flows |
|
||||||
|
| Content - Personalized greeting | ✓ | `arabic template renders correctly`, `english template renders correctly` |
|
||||||
|
| Content - Account created message | ✓ | Template assertions |
|
||||||
|
| Content - Login credentials | ✓ | `welcome email contains correct password`, `passes correct data to view` |
|
||||||
|
| Content - Login URL | ✓ | `welcome email contains login url` |
|
||||||
|
| Content - Platform intro | ✓ | Templates include feature list |
|
||||||
|
| Content - Contact info | ✓ | Templates include contact prompt |
|
||||||
|
| Language - User's preferred_language | ✓ | `uses correct arabic template`, `uses correct english template` |
|
||||||
|
| Language - Default to Arabic | ✓ | `defaults to arabic when preferred_language is null` |
|
||||||
|
| Language - Arabic template | ✓ | `arabic template renders correctly` |
|
||||||
|
| Language - English template | ✓ | `english template renders correctly` |
|
||||||
|
| Design - Professional branding | ✓ | Uses base mail template |
|
||||||
|
| Design - CTA button | ✓ | `assertSeeInHtml('تسجيل الدخول')`, `assertSeeInHtml('Login Now')` |
|
||||||
|
|
||||||
|
### Improvements Checklist
|
||||||
|
|
||||||
|
- [x] All acceptance criteria implemented
|
||||||
|
- [x] All tests passing (21/21)
|
||||||
|
- [x] Code formatted with Pint
|
||||||
|
- [x] Proper queue implementation
|
||||||
|
- [x] Bilingual support complete
|
||||||
|
- [x] Integration with client creation flows verified
|
||||||
|
|
||||||
|
### Security Review
|
||||||
|
|
||||||
|
**Status: PASS**
|
||||||
|
|
||||||
|
- Plain-text password in email is intentional per story requirements (admin-created accounts, password shown once)
|
||||||
|
- Password is captured at creation time, not retrieved from database
|
||||||
|
- Email is queued, reducing attack surface on synchronous operations
|
||||||
|
- No sensitive data logged in AdminLog (password excluded from `new_values`)
|
||||||
|
|
||||||
|
### Performance Considerations
|
||||||
|
|
||||||
|
**Status: PASS**
|
||||||
|
|
||||||
|
- Email is queued via `ShouldQueue` - no blocking on HTTP request
|
||||||
|
- Uses Laravel's built-in queue serialization
|
||||||
|
- Template rendering is lightweight markdown
|
||||||
|
|
||||||
|
### Files Modified During Review
|
||||||
|
|
||||||
|
None - no modifications required.
|
||||||
|
|
||||||
|
### Gate Status
|
||||||
|
|
||||||
|
Gate: PASS → docs/qa/gates/8.2-welcome-email.yml
|
||||||
|
|
||||||
|
### Recommended Status
|
||||||
|
|
||||||
|
[✓ Ready for Done]
|
||||||
|
|
||||||
|
The implementation is complete, well-tested, and follows all project standards. All 21 tests pass, covering trigger mechanisms, language support, content validation, and queue behavior
|
||||||
|
|
|
||||||
|
|
@ -0,0 +1,29 @@
|
||||||
|
<x-mail::message>
|
||||||
|
<div dir="rtl" style="text-align: right;">
|
||||||
|
# مرحباً بك في مكتب ليبرا للمحاماة
|
||||||
|
|
||||||
|
عزيزي {{ $user->company_name ?? $user->full_name }}،
|
||||||
|
|
||||||
|
تم إنشاء حسابك بنجاح على منصة مكتب ليبرا للمحاماة.
|
||||||
|
|
||||||
|
**بيانات تسجيل الدخول:**
|
||||||
|
|
||||||
|
- **البريد الإلكتروني:** {{ $user->email }}
|
||||||
|
- **كلمة المرور:** {{ $password }}
|
||||||
|
|
||||||
|
<x-mail::button :url="$loginUrl">
|
||||||
|
تسجيل الدخول
|
||||||
|
</x-mail::button>
|
||||||
|
|
||||||
|
**يمكنك الآن الوصول إلى:**
|
||||||
|
|
||||||
|
- حجز المواعيد
|
||||||
|
- متابعة قضاياك
|
||||||
|
- عرض التحديثات
|
||||||
|
|
||||||
|
إذا كان لديك أي استفسار، لا تتردد في التواصل معنا.
|
||||||
|
|
||||||
|
مع أطيب التحيات،<br>
|
||||||
|
{{ config('app.name') }}
|
||||||
|
</div>
|
||||||
|
</x-mail::message>
|
||||||
|
|
@ -0,0 +1,27 @@
|
||||||
|
<x-mail::message>
|
||||||
|
# Welcome to Libra Law Firm
|
||||||
|
|
||||||
|
Dear {{ $user->company_name ?? $user->full_name }},
|
||||||
|
|
||||||
|
Your account has been successfully created on the Libra Law Firm platform.
|
||||||
|
|
||||||
|
**Login Credentials:**
|
||||||
|
|
||||||
|
- **Email:** {{ $user->email }}
|
||||||
|
- **Password:** {{ $password }}
|
||||||
|
|
||||||
|
<x-mail::button :url="$loginUrl">
|
||||||
|
Login Now
|
||||||
|
</x-mail::button>
|
||||||
|
|
||||||
|
**You can now access:**
|
||||||
|
|
||||||
|
- Book consultations
|
||||||
|
- Track your cases
|
||||||
|
- View updates
|
||||||
|
|
||||||
|
If you have any questions, please don't hesitate to contact us.
|
||||||
|
|
||||||
|
Regards,<br>
|
||||||
|
{{ config('app.name') }}
|
||||||
|
</x-mail::message>
|
||||||
|
|
@ -1,5 +1,6 @@
|
||||||
<?php
|
<?php
|
||||||
|
|
||||||
|
use App\Mail\WelcomeEmail;
|
||||||
use App\Models\User;
|
use App\Models\User;
|
||||||
use App\Notifications\WelcomeAccountNotification;
|
use App\Notifications\WelcomeAccountNotification;
|
||||||
use Illuminate\Support\Facades\Notification;
|
use Illuminate\Support\Facades\Notification;
|
||||||
|
|
@ -131,52 +132,49 @@ test('welcome email contains correct password for company client', function () {
|
||||||
|
|
||||||
test('welcome email uses arabic subject for arabic preference', function () {
|
test('welcome email uses arabic subject for arabic preference', function () {
|
||||||
$user = User::factory()->individual()->create(['preferred_language' => 'ar']);
|
$user = User::factory()->individual()->create(['preferred_language' => 'ar']);
|
||||||
$notification = new WelcomeAccountNotification('password123');
|
|
||||||
|
|
||||||
$mailMessage = $notification->toMail($user);
|
$mailable = new WelcomeEmail($user, 'password123');
|
||||||
|
$envelope = $mailable->envelope();
|
||||||
|
|
||||||
expect($mailMessage->subject)->toBe('مرحباً بك في مكتب ليبرا للمحاماة');
|
expect($envelope->subject)->toBe('مرحباً بك في مكتب ليبرا للمحاماة');
|
||||||
});
|
});
|
||||||
|
|
||||||
test('welcome email uses english subject for english preference', function () {
|
test('welcome email uses english subject for english preference', function () {
|
||||||
$user = User::factory()->individual()->create(['preferred_language' => 'en']);
|
$user = User::factory()->individual()->create(['preferred_language' => 'en']);
|
||||||
$notification = new WelcomeAccountNotification('password123');
|
|
||||||
|
|
||||||
$mailMessage = $notification->toMail($user);
|
$mailable = new WelcomeEmail($user, 'password123');
|
||||||
|
$envelope = $mailable->envelope();
|
||||||
|
|
||||||
expect($mailMessage->subject)->toBe('Welcome to Libra Law Firm');
|
expect($envelope->subject)->toBe('Welcome to Libra Law Firm');
|
||||||
});
|
});
|
||||||
|
|
||||||
test('welcome email defaults to arabic when notification receives user without language', function () {
|
test('welcome email defaults to arabic when preferred_language is null', function () {
|
||||||
|
$user = User::factory()->individual()->create(['preferred_language' => 'ar']);
|
||||||
|
// Simulate a scenario where preferred_language could be null in memory
|
||||||
|
$user->preferred_language = null;
|
||||||
|
|
||||||
|
$mailable = new WelcomeEmail($user, 'password123');
|
||||||
|
$envelope = $mailable->envelope();
|
||||||
|
|
||||||
|
expect($envelope->subject)->toBe('مرحباً بك في مكتب ليبرا للمحاماة');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('welcome email uses correct arabic template', function () {
|
||||||
$user = User::factory()->individual()->create(['preferred_language' => 'ar']);
|
$user = User::factory()->individual()->create(['preferred_language' => 'ar']);
|
||||||
|
|
||||||
// Simulate a scenario where preferred_language could be missing
|
$mailable = new WelcomeEmail($user, 'password123');
|
||||||
// by creating a mock object that returns null for preferred_language
|
$content = $mailable->content();
|
||||||
$mockUser = new class($user)
|
|
||||||
{
|
|
||||||
public $preferred_language = null;
|
|
||||||
|
|
||||||
private $user;
|
expect($content->markdown)->toBe('emails.welcome.ar');
|
||||||
|
});
|
||||||
|
|
||||||
public function __construct($user)
|
test('welcome email uses correct english template', function () {
|
||||||
{
|
$user = User::factory()->individual()->create(['preferred_language' => 'en']);
|
||||||
$this->user = $user;
|
|
||||||
}
|
|
||||||
|
|
||||||
public function __get($name)
|
$mailable = new WelcomeEmail($user, 'password123');
|
||||||
{
|
$content = $mailable->content();
|
||||||
if ($name === 'preferred_language') {
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
|
|
||||||
return $this->user->$name;
|
expect($content->markdown)->toBe('emails.welcome.en');
|
||||||
}
|
|
||||||
};
|
|
||||||
|
|
||||||
$notification = new WelcomeAccountNotification('password123');
|
|
||||||
$mailMessage = $notification->toMail($mockUser);
|
|
||||||
|
|
||||||
expect($mailMessage->subject)->toBe('مرحباً بك في مكتب ليبرا للمحاماة');
|
|
||||||
});
|
});
|
||||||
|
|
||||||
// ===========================================
|
// ===========================================
|
||||||
|
|
@ -190,12 +188,12 @@ test('welcome email passes correct data to view', function () {
|
||||||
'preferred_language' => 'en',
|
'preferred_language' => 'en',
|
||||||
]);
|
]);
|
||||||
|
|
||||||
$notification = new WelcomeAccountNotification('testPassword123');
|
$mailable = new WelcomeEmail($user, 'testPassword123');
|
||||||
$mailMessage = $notification->toMail($user);
|
$content = $mailable->content();
|
||||||
|
|
||||||
expect($mailMessage->viewData['user']->id)->toBe($user->id);
|
expect($content->with['user']->id)->toBe($user->id);
|
||||||
expect($mailMessage->viewData['password'])->toBe('testPassword123');
|
expect($content->with['password'])->toBe('testPassword123');
|
||||||
expect($mailMessage->viewData['locale'])->toBe('en');
|
expect($content->with['loginUrl'])->toBe(route('login'));
|
||||||
});
|
});
|
||||||
|
|
||||||
test('welcome email passes company name for company clients', function () {
|
test('welcome email passes company name for company clients', function () {
|
||||||
|
|
@ -204,11 +202,51 @@ test('welcome email passes company name for company clients', function () {
|
||||||
'preferred_language' => 'ar',
|
'preferred_language' => 'ar',
|
||||||
]);
|
]);
|
||||||
|
|
||||||
$notification = new WelcomeAccountNotification('companyPass');
|
$mailable = new WelcomeEmail($user, 'companyPass');
|
||||||
$mailMessage = $notification->toMail($user);
|
$content = $mailable->content();
|
||||||
|
|
||||||
expect($mailMessage->viewData['user']->company_name)->toBe('Test Company Ltd');
|
expect($content->with['user']->company_name)->toBe('Test Company Ltd');
|
||||||
expect($mailMessage->viewData['locale'])->toBe('ar');
|
expect($content->markdown)->toBe('emails.welcome.ar');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('arabic template renders correctly', function () {
|
||||||
|
$user = User::factory()->individual()->create([
|
||||||
|
'full_name' => 'محمد أحمد',
|
||||||
|
'email' => 'mohammad@example.com',
|
||||||
|
'preferred_language' => 'ar',
|
||||||
|
]);
|
||||||
|
|
||||||
|
$mailable = new WelcomeEmail($user, 'password123');
|
||||||
|
|
||||||
|
$mailable->assertSeeInHtml('مرحباً بك في مكتب ليبرا للمحاماة');
|
||||||
|
$mailable->assertSeeInHtml('محمد أحمد');
|
||||||
|
$mailable->assertSeeInHtml('mohammad@example.com');
|
||||||
|
$mailable->assertSeeInHtml('password123');
|
||||||
|
$mailable->assertSeeInHtml('تسجيل الدخول');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('english template renders correctly', function () {
|
||||||
|
$user = User::factory()->individual()->create([
|
||||||
|
'full_name' => 'John Doe',
|
||||||
|
'email' => 'john@example.com',
|
||||||
|
'preferred_language' => 'en',
|
||||||
|
]);
|
||||||
|
|
||||||
|
$mailable = new WelcomeEmail($user, 'password456');
|
||||||
|
|
||||||
|
$mailable->assertSeeInHtml('Welcome to Libra Law Firm');
|
||||||
|
$mailable->assertSeeInHtml('John Doe');
|
||||||
|
$mailable->assertSeeInHtml('john@example.com');
|
||||||
|
$mailable->assertSeeInHtml('password456');
|
||||||
|
$mailable->assertSeeInHtml('Login Now');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('welcome email contains login url', function () {
|
||||||
|
$user = User::factory()->individual()->create(['preferred_language' => 'en']);
|
||||||
|
|
||||||
|
$mailable = new WelcomeEmail($user, 'password123');
|
||||||
|
|
||||||
|
$mailable->assertSeeInHtml(route('login'));
|
||||||
});
|
});
|
||||||
|
|
||||||
// ===========================================
|
// ===========================================
|
||||||
|
|
@ -227,6 +265,28 @@ test('welcome notification uses queueable trait', function () {
|
||||||
expect($traits)->toContain(\Illuminate\Bus\Queueable::class);
|
expect($traits)->toContain(\Illuminate\Bus\Queueable::class);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('welcome email mailable implements should queue interface', function () {
|
||||||
|
$user = User::factory()->individual()->create();
|
||||||
|
$mailable = new WelcomeEmail($user, 'password');
|
||||||
|
|
||||||
|
expect($mailable)->toBeInstanceOf(\Illuminate\Contracts\Queue\ShouldQueue::class);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('welcome email mailable uses queueable trait', function () {
|
||||||
|
$traits = class_uses(WelcomeEmail::class);
|
||||||
|
|
||||||
|
expect($traits)->toContain(\Illuminate\Bus\Queueable::class);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('notification returns welcome email mailable', function () {
|
||||||
|
$user = User::factory()->individual()->create();
|
||||||
|
$notification = new WelcomeAccountNotification('password123');
|
||||||
|
|
||||||
|
$mailable = $notification->toMail($user);
|
||||||
|
|
||||||
|
expect($mailable)->toBeInstanceOf(WelcomeEmail::class);
|
||||||
|
});
|
||||||
|
|
||||||
// ===========================================
|
// ===========================================
|
||||||
// Admin Exclusion Tests
|
// Admin Exclusion Tests
|
||||||
// ===========================================
|
// ===========================================
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue